TypeError: Cannot set property 'readyState' of undefined (when using upgrade listener) #1660
Closed
1 task done
Comments
|
I can't reproduce: 'use strict';
const http = require('http');
const WebSocket = require('ws');
const data = `<!DOCTYPE html>
<html>
<head>
<meta charset="utf-8">
</head>
<body>
<script>
(function () {
var ws = new WebSocket('ws://localhost:8080');
ws.onmessage = function(evt) {
console.log(evt.data);
};
})();
</script>
</body>
</html>`;
const server = http.createServer();
const wss = new WebSocket.Server({ noServer: true });
wss.on('connection', function(ws) {
ws.send('Hello');
});
server.on('request', (req, res) => {
res.setHeader('Content-Type', 'text/html');
res.end(data);
});
server.on('upgrade', (req, socket, head) => {
if (true) {
wss.handleUpgrade(req, socket, head, (ws) => {
wss.emit('connection', ws, req);
});
}
});
server.listen(8080, () => {
console.log('Listening on *:8080');
});Make sure to specify the |
|
Thanks for the quick response! Indeed, the |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
issue.
I found the other issues #1591 and #1564 but I think the root cause here is different, althought he error is the same. Or at least the "if" clause has been removed again, which makes this error occur again.
Description
When I add the following snippet for attaching an upgrade listener for the connection, I encounter the following error message. I could narrow down the error to the upgrade request.
Reproducible in:
Steps to reproduce:
See error
Expected result:
No error
Actual result:
Error from above is shown
Attachments:
Test html +js for connecting to the websocket server.
websockettest.html.txt
The text was updated successfully, but these errors were encountered: