Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Marketplace Page Settings data before submitting to the Marketplace #4429

Open
johnsicili opened this issue Nov 15, 2024 · 4 comments
Labels
area:marketplace prio:2 Always look for prio:1 issues first before working on prio:2 type:feat Features and enhancements

Comments

@johnsicili
Copy link
Contributor

Currently you have to submit the Project to the Marketplace to expose the per-page Marketplace settings.

This is counterintuitive because those page settings need to be filled out before it's accepted in the Marketplace.

Expectation is to have all fields that need to be set before submitting for review.

image
@johnsicili johnsicili added type:feat Features and enhancements prio:2 Always look for prio:1 issues first before working on prio:2 area:marketplace labels Nov 15, 2024
@TrySound
Copy link
Member

Moreover the project should appear as "personal marketplace product" or "account marketplace product"

@kof
Copy link
Member

kof commented Nov 16, 2024

Agree. The reason its hidden was to avoid showing stuff in page settings that isn't used unless its submitted to the marketplace. This makes page settings too busy.

Problem though that before I submit I should be able to go and check the page settings for the marketplace.

I suggest we show the marketplace page settings, but only the upper part, initially, only when user turns switch on, then we show the rest, this way its not as much space.

Additionally we could add a hint if project is not submitted to the marketplace that this setting has no effect and tell user where to check the marketplace settings for submission.

image

@johnsicili
Copy link
Contributor Author

I agree that hiding it for people that don't need it is good.

Maybe we have a project-wide toggle in Project Settings that's like "Enable Marketplace Mode" or something so it's out of the way and with the other Marketplace settings.

@kof
Copy link
Member

kof commented Nov 16, 2024

Well marketplace settings is the project-wide toggle. It's just currently anchored with submission for review. I think I pointed out to @TrySound initially that the flow is not logical, but we decided to try.

The option I proposed at the time was to have a first checkbox in the marketplace settings that would turn that marketplace mode on before you see any marketplace settings, only after that one would see both settings in the project settings marketplace and page settings.

The UX here is also challenging, but we need to revisit it for sure. Something along the lines of a toggle that does nothing but turning on the settings would already solve the problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:marketplace prio:2 Always look for prio:1 issues first before working on prio:2 type:feat Features and enhancements
Projects
None yet
Development

No branches or pull requests

3 participants