New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

encodePeer in client.js doesn't check if port is our of range #175

Open

bjackson opened this issue Oct 18, 2017 · 0 comments

bjackson commented Oct 18, 2017

encodePeer doesn't check for out of bounds values before writing them to a Buffer, which can cause an error to be thrown.

I would submit a PR, but I'm not sure what the behavior should be when a peer with a port that is outside the range is discovered.

https://github.com/webtorrent/bittorrent-dht/blob/master/client.js#L618

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment