Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Electron 4 support #1564

Closed
qarkai opened this issue Apr 12, 2019 · 3 comments
Closed

Electron 4 support #1564

qarkai opened this issue Apr 12, 2019 · 3 comments

Comments

@qarkai
Copy link

qarkai commented Apr 12, 2019

What version of WebTorrent Desktop?
0.20.0 (from https://aur.archlinux.org/packages/webtorrent-desktop/)

What operating system and version?
Arch Linux

What did you do?
Upgraded to electron-4.1.1

What did you expect to happen?
webtorrent-desktop started

What actually happened?

A JavaScript error occurred in the main process
Uncaught Exception:
TypeError: app.makeSingleInstance is not a function
    at Object.<anonymous> (/usr/lib/webtorrent-desktop/build/main/index.js:41:20)
    at Object.<anonymous> (/usr/lib/webtorrent-desktop/build/main/index.js:228:3)
    at Module._compile (internal/modules/cjs/loader.js:693:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:704:10)
    at Module.load (internal/modules/cjs/loader.js:602:32)
    at tryModuleLoad (internal/modules/cjs/loader.js:541:12)
    at Function.Module._load (internal/modules/cjs/loader.js:533:3)
    at Module.require (internal/modules/cjs/loader.js:640:17)
    at require (internal/modules/cjs/helpers.js:20:18)
    at Object.<anonymous> (/usr/lib/webtorrent-desktop/index.js:1:156)

@qarkai
Copy link
Author

qarkai commented Apr 20, 2019

Switch to branch greenkeeper/electron-4.1.4 doesn't help.

@vitlav
Copy link

vitlav commented May 5, 2019

$ sed -i -e "s/shouldQuit = app.makeSingleInstance(\(.*\))/shouldQuit = !app.requestSingleInstanceLock()/" src/main/index.js

@feross
Copy link
Member

feross commented Jul 20, 2019

This is being handled in this PR: #1590

@feross feross closed this as completed Jul 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants