Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error in preferences page path-selector when there is no default value #1652

Closed
hicom150 opened this issue Aug 15, 2019 · 2 comments · Fixed by #1704
Closed

Error in preferences page path-selector when there is no default value #1652

hicom150 opened this issue Aug 15, 2019 · 2 comments · Fixed by #1704

Comments

@hicom150
Copy link
Contributor

What version of this package are you using?
Latest master commit afd3b84

What operating system, Node.js, and npm version?
OSX Yosemite (10.10.5), Node.js v8.16.0, npm 6.10.2

What happened?
In preferences page when you try to push CHANGE button in Folder to watch or you try to push CHANGE button in External player an error message is throw in debug console and dialog does not open

Error: Could not call remote method 'showOpenDialog'. Check that the method signature is correct. Underlying error: Default path must be a string

What did you expect to happen?
I expect the dialog to open

Are you willing to submit a pull request to fix this bug?
Sure! 😎

@hicom150
Copy link
Contributor Author

Should be fixed in #1653 😉

@feross
Copy link
Member

feross commented Aug 18, 2019

Fixed by #1498

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants