Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev #2

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

Dev #2

wants to merge 5 commits into from

Conversation

jinzhongjia
Copy link

No description provided.

@jinzhongjia jinzhongjia linked an issue Jan 17, 2024 that may be closed by this pull request
@jinzhongjia
Copy link
Author

Now, we can do this:
image
However, I haven't written the actual code to introduce a dynamic link library, so it's direct dlopen for now

@jinzhongjia
Copy link
Author

api adaption is ok, but I need to write examples and import dynamic link library

@jinzhongjia jinzhongjia self-assigned this Jan 20, 2024
@jinzhongjia jinzhongjia added the enhancement New feature or request label Jan 20, 2024
@jinzhongjia
Copy link
Author

The current bunjs embedded file function is not perfect, and there seems to be some strange problems.
and the dlopen has an issue: oven-sh/bun#6517

So I decided to stop bunjs adaptation for the time being (the possible introduction of dynamic libraries failed due to this issue)

@jinzhongjia jinzhongjia marked this pull request as draft January 21, 2024 05:06
@jinzhongjia jinzhongjia marked this pull request as ready for review April 4, 2024 12:17
@jinzhongjia jinzhongjia marked this pull request as draft April 6, 2024 08:21
- `show`
- `startServer`
- `showWv`
- `setKiosk`
- `setHighContrast`
- `setHide`
- `setSize`
- `setPosition`
- `getUrl`
- `getNewWindowId`
- `browserExist`
- `getBestBrowser`
- `exit`
- `clean`
@jinzhongjia
Copy link
Author

@sensiblearts Maybe you should check the bind function in the PR. If thread safety is not turned on, it will cause a null pointer error. But starting thread safety will cause the thread to be blocked and the callback cannot be executed normally. It seems to be a multi-threading problem.

@jinzhongjia
Copy link
Author

I think there is a problem with the JSCallback design of bunjs

@sensiblearts
Copy link

@jinzhongjia we had a death in the family and I'm occupied for about a month helping my mother in law move across the country. I'll be back in touch in a month or so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adaptive progress
2 participants