[bug] setFileHandler() gives invalid http response

[DevRubicate]

setFileHandler() appears to serve some sort of invalid http response, making it nonfunctional.

// Show the window
myWindow.show(myHtml); // Or myWindow.show('./myFile.html');

myWindow.setFileHandler((myUrl: URL) => {
  if (myUrl.pathname === '/app.js') return "console.log('hello from client')";
  throw new Error(`Unknown request "${myUrl.pathname}""`)
});

// Wait until all windows get closed
await WebUI.wait();

console.log("Thank you.");

I am unfortunately unable to debug why the response is invalid, curl -v was not able to give anything useful.

I am on Windows 11.

[AlbertShown]

To debug this, you have just to use the debug version of webui, this give the full webui logs.
However, I guess webui 2.4 will add HTTP header to the user body response, but webui 2.5 request the user to return the full complete HTTP response (Header + Body).

Try something like:

if (myUrl.pathname === '/app.js') {
  const headers = `HTTP/1.1 200 OK\r\nContent-Type: application/javascript\r\n`;
  const body = "console.log('hello from client');";
  return `${headers}\r\n${body}`;
}

[DevRubicate]

Aha! That is a good change, I approve.

However, when I try your example, I get one more byte of output than I am supposed to get. I checked with curl and it the extra byte is 0x00, I assume this is the termination of a C-style string?

[AlbertShown]

I don't know if this extra byte is added by Deno wrapper, or by webui core.
Can you try adding HTTP content len and see if it gets fixed?

if (myUrl.pathname === '/app.js') {
  const body = "console.log('hello from client');";
  const headers = `HTTP/1.1 200 OK\r\nContent-Type: application/javascript\r\nContent-Length: ${body.length}\r\n`;
  return `${headers}\r\n${body}`;
}

[DevRubicate]

It does fix it, thank you.