Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

We need a test to ensure that setup.py is capturing all the modules. #562

Open
bw4sz opened this issue Dec 4, 2023 · 1 comment
Open
Assignees

Comments

@bw4sz
Copy link
Collaborator

bw4sz commented Dec 4, 2023

In #561 we ended up shipping a pypi version that didn't have a module deepforest.models. This is because it existed in the git repo and so passed all the tests, but wasn't properly passing. Is there a way to mock setup.py to create a tarball and then check if all the modules are in the tarball?

The key line is

packages=find_packages(),

@ethanwhite
Copy link
Member

Just came across this recommendation for directory structure to avoid this sort of issue:
https://www.pyopensci.org/python-package-guide/package-structure-code/python-package-structure.html#the-src-layout-and-testing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants