Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

html5 shiv in _head.html.pug #219

Closed
Youdaman opened this issue Sep 24, 2018 · 2 comments
Closed

html5 shiv in _head.html.pug #219

Youdaman opened this issue Sep 24, 2018 · 2 comments
Assignees
Labels

Comments

@Youdaman
Copy link

Should use a != instead of = before javascript_include_tag otherwise source shows html characters:

<!--[if lt IE 9]>&lt;script src=&quot;http://html5shiv.googlecode.com/svn/trunk/html5.js&quot; type=&quot;text/javascript&quot;&gt;&lt;/script&gt;<![endif]-->
@Youdaman
Copy link
Author

@alessandro-fazzi
Copy link
Member

Hello @Youdaman and thanks for reporting this, but I will have an higher approach to the problem:

  • this is a forgotten piece of code
  • also if it's just inside a starter theme, I do not intend anymore to remind developers about <IE9 support

So: said you fix is ok, I'll fix the vanilla theme by removing this if lt IE 9 anachronistic snippet :)

On my way to publishing the fix in a minor version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants