Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ feat(config): override config bools with env vars #9

Merged
merged 1 commit into from
Feb 5, 2024

Conversation

welpo
Copy link
Owner

@welpo welpo commented Feb 5, 2024

Summary

This PR introduces the ability to override boolean configuration flags through environment variables. Example, with sumi.toml containing quiet = true, you can do:

GIT_SUMI_QUIET=false git sumi '👷 misc(CI): rename git-sumi job'

And quiet will be correctly set to false:

💬 Input: "👷 misc(CI): rename git-sumi job"
✅ All 10 checks passed.

How has this been tested?

  • Manual tests
  • Unit tests
  • Integration tests

Type of change

  • Bug fix (fixes an issue without altering functionality)
  • New feature (adds non-breaking functionality)
  • Breaking change (alters existing functionality)
  • UI/UX improvement (enhances user interface without altering functionality)
  • Refactor (improves code quality without altering functionality)
  • Documentation update
  • Other (please describe below)

Checklist

  • I have read the contributing guidelines.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • My code follows the code style of this project.
  • I have formatted the code with cargo fmt.
  • My change requires updating the documentation.
  • I have updated the documentation accordingly.

@welpo welpo added the enhancement New feature or request label Feb 5, 2024
@welpo welpo merged commit e84a27e into main Feb 5, 2024
6 of 7 checks passed
@welpo welpo deleted the feat/env-bool-override branch February 5, 2024 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant