-
-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missing Docker version tags #41
Comments
We had a For some reason |
@Siemko any ideas how we can fix the CI? https://travis-ci.com/github/wemake-services/caddy-gen/builds/176069791 |
If the image isn't tagged by the Git commit tag it's probably due to an misconfigured, or not configured at all, build rule. |
Upon further investigation I see that a repository of mine is suffering from the same issue. I've written their support team. |
I've haven't heard anything back from the support team. My suggestion is that a manual tagging is done. I'd do it myself if I had access to the registry. |
The thing is: we don't what to release |
Do you mean release 0.4.0? Either way, I haven't used Travis before but if you point me in the right direction I can take a look |
Yes, Here's what's wrong: https://travis-ci.com/github/wemake-services/caddy-gen |
I've created the following pull request #42. Fixing the curl command was simply done by sleeping for 1 second. However simply doing a curl request is a bit too little. So I wanted to assert the http status code as well. Because port 80 redirects to 443 it returns 308. Following that redirect results in the following.
I'm guessing that is due to lack of configuration but I'm not sure. |
Any chance of pushing a new image to dockerhub?
Later Caddy versions have more features. Took me ages to realise things like If you want I can add a GitHub Action CI script to build & push to docker hub :) |
Please! It would be very helpful |
Hopefully you'll push a new tag/release soon @sobolevn :) |
The latest commit includes breaking changes. Which caused a server of mine to become inaccessible. Since there's no image tagged with version 0.3.0 on Docker Hub I can't easily revert.
Also a tag, possible 0.4.0, for the aforementioned commit/release would be nice.
The text was updated successfully, but these errors were encountered: