Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Umbrella apps support #321

Closed
nurges opened this issue Apr 19, 2018 · 2 comments
Closed

Umbrella apps support #321

nurges opened this issue Apr 19, 2018 · 2 comments

Comments

@nurges
Copy link

nurges commented Apr 19, 2018

Elchemy gives an error when executing 'mix compile' in an umbrella app.

It is caused by a format command in elchemy/lib/mix/tasks/compile.elchemy.ex

Mix.Task.run("format", ["lib/**/*.elchemy.{ex,exs}"])

A workaround is to create a 'lib' folder in umbrella app root and copy 'Hello.elchemy.ex' into this folder.

@wende
Copy link
Owner

wende commented Apr 19, 2018

@nurges Great find!
I think given that we just want to format all of the elchemy files it could be changed to just "./**/*.elchemy.{ex,exs}" assuming such a wildcard works correctly

@wende
Copy link
Owner

wende commented Apr 28, 2018

After investigating an issue it seems that to make it work for umbrella apps it'd require a lot of changes to the main bash file, which is undergoing a big overhaul anyway due to #288.

Elchemy can still be used in every single app inside of the umbrella app. That means that the code between the apps can be used on an elixir interop (with ffi or using Elixir injection) but not on an Elchemy interop (It won't see the types out of the app)

Putting this to the backlog after dependency gets of #288 gets fixed

@wende wende closed this as completed Apr 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants