Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'core' app should not depend on apps that depend themselves on core (circular dependency #37

Open
jcbalmeida opened this issue Aug 26, 2021 · 0 comments
Labels
enhancement New feature or request

Comments

@jcbalmeida
Copy link

https://github.com/Ilhasoft/weni-marketplace-engine/blob/e1791d7fb6642eae66fc4527154b55c2a43f0452/marketplace/core/types/base.py#L6-L7

These imports does not break the application, but this type of circular dependencies can lead to high dificulty to maintain and improve the project in the future.

The correct thing would be for the other apps to register themselves in AppType when initializing (in AppConfig.init())

@jcbalmeida jcbalmeida added the enhancement New feature or request label Aug 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant