-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
添加 lint 配置以及相应模板 #80
Merged
Merged
添加 lint 配置以及相应模板 #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
感谢eslint的PR,这个也是一直想做但没时间做的。 |
是的,理论上的效果,应该是把模板部分拆成单独的项目,或者就算不是拆成单独的项目也是可以有很多共用的部分。 不管是不是单独的,但是总归结果是要把共用的部分拆分出来,这个地方还没有想好一个比较相对优雅的方式来做替换,毕竟涉及到 4空格到2空格,分号替换等。 考虑到两个模板毕竟“不大”,所以做了妥协处理;当然如果有更好一点的做法就更好了。 PS:有一个想法是建单独项目,实时下载然后作为模板内容。 |
修改了一下,只保留了一份template。否则以后要维护两份。 |
👍 |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
现在模板分为两种:
--standard
参数,有的话创建的项目就是 不带分号+两个空格创建项目的时候,默认会增加 eslint 和 editorconfig 配置,如果不想要的话可以在创建项目的时候增加
--no-lint