Redux Support #93
Merged
Redux Support #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gcaufy
reviewed
Apr 14, 2017
| @@ -113,7 +113,7 @@ export default { | |||
| return matchs.replace(/[^\.\w'"]([a-z_\$][\w\d\._\$]*)/ig, (match, word, n) => { | |||
| //console.log(matchs + '------' + match + '--' + word + '--' + n); | |||
| let char = match[0]; | |||
| let tmp = word.match(/^(\w+)(.*)/); | |||
| let tmp = word.match(/^([\w$]+)(.*)/); | |||
There was a problem hiding this comment.
因为对 redux 处理中默认加入了 $state 这个 computed 的值方便直接使用。
而且加上 $ 也是合理的吧，毕竟从变量上来说是可以有$的
There was a problem hiding this comment.
这个是在 [] 中的，应该不用转义就好
packages/wepy-cli/src/wepy.js
Outdated
|
|
||
| if (!config.empty) { | ||
| dependencies.push('wepy-com-toast'); | ||
| dependencies.push('wepy-async-function'); | ||
| } | ||
| if (useRedux) { | ||
| dependencies.push.apply(dependencies, reduxDeps); |
There was a problem hiding this comment.
dependencies = dependencies.concat(reduxDeps)
packages/wepy-cli/src/wepy.js
Outdated
|
|
||
| if (!config.empty) { | ||
| dependencies.push('wepy-com-toast'); | ||
| dependencies.push('wepy-async-function'); | ||
| } | ||
| if (useRedux) { | ||
| dependencies.push.apply(dependencies, reduxDeps); | ||
| } | ||
|
|
||
| if (config.lint) { | ||
| devDependencies.push.apply(devDependencies, eslintDeps); |
packages/wepy-cli/src/wepy.js
Outdated
| @@ -94,6 +106,21 @@ let generateProject = (name, config) => { | |||
| // --on-lint will not copy eslint config | |||
| if (['.editorconfig', '.eslintignore', '.eslintrc'].indexOf(file) !== -1 && !config.lint) | |||
| return; | |||
| // 只有 redux 的项目拷贝 redux 相关内容 且做替换 | |||
| const unReduxFiles = ['src/app.wpy', 'src/components/counter.wpy']; | |||
There was a problem hiding this comment.
在非--redux模式下，生成的template中并没有排除 redux 模式的相关文件，这样会导致普通模式下文件再次build报错。
| const store = configStore() | ||
| setStore(store) | ||
|
|
||
| export default class extends wepy.app { |
There was a problem hiding this comment.
示例不够充分，目前只有一个counter组件使用了redux。需要再加入一个组件，看不同组件中的同一数据流是否存在问题。
There was a problem hiding this comment.
这个在我的原始demo是有的，但后来我思考的是 counter 是多个实例的，所以也算是“多”个组件了
Gcaufy
reviewed
Apr 14, 2017
| @@ -128,6 +128,7 @@ export default { | |||
| }, | |||
|
|
|||
| npmHack (filename, code) { | |||
| code = code.replace(/process\.env\.NODE_ENV/g, JSON.stringify(process.env.NODE_ENV)); | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add redux (默认全家桶：redux-actions redux-promise)
#89