Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

just some observations #1

Open
razcore-rad opened this issue Dec 18, 2013 · 1 comment
Open

just some observations #1

razcore-rad opened this issue Dec 18, 2013 · 1 comment

Comments

@razcore-rad
Copy link

I was looking at your code and well done, very clearly explained. I do have an observation. You say that the View and Controller is tightly coupled with the Model by that import statement: import model but the model module is never used, that is, the coupling is actually done by the calls to the constructors for View and Controller, the import itself is meaningless. Other than this minor observation, this is a really good job you did here, very nice to read.

@wesleywerner
Copy link
Owner

Ah thanks for pointing that out, very valid and I can't think of any reason now to import the model, it is just there to make a point how the objects link together.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants