Allow references for responses fixes #84 #89
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trekdemo
force-pushed
the
allow_references_for_responses
branch
from
38ec1ac
to
8479edf
Compare
|
@westfield-labs are you still maintaining this project? |
|
@hornc Sorry to bother you, but I saw you did the latest merge. Any thoughts on this? |
lucasrenan
reviewed
Jan 18, 2017
| when response_data.schema | ||
| Fragment.new(['#', 'paths', path, verb, 'responses', response_code, 'schema']) | ||
| when (ref = response_data['$ref']) | ||
| Fragment.new(ref.split('/')) |
There was a problem hiding this comment.
what's the result here? seems you are missing 'schema'
Fragment.new(ref.split('/').push('schema'))There was a problem hiding this comment.
@lucasrenan I'm not sure why would we missing a 'schema'. ref holds the value of the path to the schema definition. Eg.: in the added test it's '#/definitions/service'. And that's exactly the path to the schema definition at the end of file: https://github.com/westfieldlabs/apivore/pull/89/files#diff-65c886d34e6323742cba1cd52731ecc5R129
trekdemo
force-pushed
the
allow_references_for_responses
branch
2 times, most recently
from
24cd409
to
cb62017
Compare
trekdemo
force-pushed
the
allow_references_for_responses
branch
from
cb62017
to
aac8f01
Compare
|
@ashoda any update on the review? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #84