Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problems with default waitUntil load in call to setContent #47

Open
spencerr-carimus opened this issue Sep 13, 2021 · 0 comments
Open

Comments

@spencerr-carimus
Copy link

await page.setContent(html);

As it is now, this call to page.setContent uses the default waitUntil of load (https://github.com/puppeteer/puppeteer/blob/v1.11.0/docs/api.md#pagesetcontenthtml-options).

This causes some issues when you're trying to use a Handlebars and/or MJML template. It would be good if you could pass the waitUntil for setting the DOM content to whatever the user desires, defaulting to Puppeteer's default.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant