Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scope pubsub topics to the cluster namespace. #5

Closed
lthibault opened this issue Feb 3, 2022 · 1 comment
Closed

Scope pubsub topics to the cluster namespace. #5

lthibault opened this issue Feb 3, 2022 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers
Milestone

Comments

@lthibault
Copy link
Collaborator

Topics are currently scoped globally, meaning that a name collision occurs between the topics joined by the PubSub capability and the cluster namespace. For example, calling n.PubSub().Join("foo") against a node started via ww start -ns foo will return pubsub.capnp:Topic.publish: topic already exists.

To remedy this, we should add the cluster namespace to each topic as a dot-separated prefix. Thus, Join("foo") from our previous example would produce the fully-qualified topic foo.foo.

Interestingly, we might use this mechanism to support an empty "" that is nonetheless distinct from the cluster topic (it would map to the topic .).

@lthibault lthibault added enhancement New feature or request good first issue Good for newcomers labels Feb 3, 2022
@lthibault lthibault added this to the 0.1.0 Public Beta Release milestone Feb 3, 2022
@lthibault
Copy link
Collaborator Author

Implemented in wetware/rs@fe32261.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant