Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't catch error #4070

Closed
1 task done
AlansaladA opened this issue Jun 20, 2024 · 3 comments
Closed
1 task done

Can't catch error #4070

AlansaladA opened this issue Jun 20, 2024 · 3 comments
Labels
Needs Reproduction Misc: Needs Reproduction

Comments

@AlansaladA
Copy link

Check existing issues

Describe the bug

When I call the approve method of the contract or operate to import tokens into the wallet(walletClient.data?.watchAsset), if I click reject in metamask, the user rejection cannot be captured in the catch and the execution continues.

But when I try to switch back to version 2.9.9, I can catch the error. I want to know if there is any update on error handler in the new version?

Link to Minimal Reproducible Example

No response

Steps To Reproduce

No response

What Wagmi package(s) are you using?

wagmi

Wagmi Version

2.10.2

Viem Version

2.15.1

TypeScript Version

No response

Anything else?

No response

@tmm tmm added the Needs Reproduction Misc: Needs Reproduction label Jun 20, 2024
Copy link
Contributor

Hello @AlansaladA.

Please provide a minimal reproduction using StackBlitz, TypeScript Playground (for type issues), or a separate minimal GitHub repository.

Minimal reproductions are required as they save us a lot of time reproducing your config/environment and issue, and allow us to help you faster.

Once a minimal reproduction is added, a team member will confirm it works, then re-open the issue.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jun 20, 2024
@AlansaladA
Copy link
Author

AlansaladA commented Jun 21, 2024

@tmm , I have added a minimal reproduction. Could you please reopen this Issue and take a look? Thank you!
The minimal reproduction

Copy link
Contributor

github-actions bot commented Jul 6, 2024

This issue has been locked since it has been closed for more than 14 days.

If you found a concrete bug or regression related to it, please open a new bug report with a reproduction against the latest Wagmi version. If you have any questions or comments you can create a new discussion thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Needs Reproduction Misc: Needs Reproduction
Projects
None yet
Development

No branches or pull requests

2 participants