Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EIP-6963 connectors are not announced becuase of Bitski wallet #4090

Closed
1 task done
magiziz opened this issue Jun 27, 2024 · 3 comments
Closed
1 task done

EIP-6963 connectors are not announced becuase of Bitski wallet #4090

magiziz opened this issue Jun 27, 2024 · 3 comments

Comments

@magiziz
Copy link
Contributor

magiziz commented Jun 27, 2024

Check existing issues

Describe the bug

If you install Bitski wallet and get this view:

bitski-view

The other EIP-6963 connectors will not get announced unless you disable the Bitski wallet extension.

image

Link to Minimal Reproducible Example

https://github.com/magiziz/wagmi-eip6963-repro

Steps To Reproduce

  • Install Bitski wallet and have other wallet extensions installed
  • Refresh the page and you'll see no EIP-6963 connectors getting annoucned. It's probably because of this error:
image

What Wagmi package(s) are you using?

wagmi

Wagmi Version

2.10.7

Viem Version

2.16.3

TypeScript Version

5.5.2

Anything else?

No response

@tmm tmm added Good First Issue Misc: Good First Issue and removed Good First Issue Misc: Good First Issue labels Jun 27, 2024
@tmm
Copy link
Member

tmm commented Jun 27, 2024

Looks like this is because Bitski decided to not follow EIP-6963 for some reason, using walletId instead of rdns. Should follow up with them!

001060_Google Chrome_2024-06-27-09 53 50@2x

@tmm tmm closed this as not planned Won't fix, can't repro, duplicate, stale Jun 27, 2024
@tmm
Copy link
Member

tmm commented Jun 27, 2024

Looks like Bitski is shutting down in three days so probably not worth even following up.

Copy link
Contributor

This issue has been locked since it has been closed for more than 14 days.

If you found a concrete bug or regression related to it, please open a new bug report with a reproduction against the latest Wagmi version. If you have any questions or comments you can create a new discussion thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants