Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

coinbaseWallet > appLogoUrl not working and default favicon url won't add / after domain #4119

Closed
1 task done
rajpraful opened this issue Jul 8, 2024 · 3 comments
Closed
1 task done
Labels
Needs Reproduction Misc: Needs Reproduction

Comments

@rajpraful
Copy link

Check existing issues

Describe the bug

I am passing the appLogoUrl to the function, but the logo is broken in UI. After inspecting I found that it's using default favicon itself.

Favicon works for me but it's broken as it's missing / in the image URL after the domain like below
https://domainNameassets/favicons/apple-touch-icon-180x180.png

Where the expected URL is https://domainName/assets/favicons/apple-touch-icon-180x180.png

Link to Minimal Reproducible Example

No response

Steps To Reproduce

No response

What Wagmi package(s) are you using?

@wagmi/connectors

Wagmi Package(s) Version(s)

5.0.21

Viem Version

2.x

TypeScript Version

No response

Anything else?

No response

@rajpraful rajpraful changed the title coinbaseWallet > appLogoUrl not working and default favicon url doesn't adding / after domain coinbaseWallet > appLogoUrl not working and default favicon url won't add / after domain Jul 8, 2024
@tmm tmm added the Needs Reproduction Misc: Needs Reproduction label Jul 8, 2024
Copy link
Contributor

github-actions bot commented Jul 8, 2024

Hello @rajpraful.

Please provide a minimal reproduction using StackBlitz, TypeScript Playground (for type issues), or a separate minimal GitHub repository.

Minimal reproductions are required as they save us a lot of time reproducing your config/environment and issue, and allow us to help you faster.

Once a minimal reproduction is added, a team member will confirm it works, then re-open the issue.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jul 8, 2024
@tmm
Copy link
Member

tmm commented Jul 8, 2024

Probably worth following up upstream on Coinbase Wallet SDK https://github.com/coinbase/coinbase-wallet-sdk

Copy link
Contributor

This issue has been locked since it has been closed for more than 14 days.

If you found a concrete bug or regression related to it, please open a new bug report with a reproduction against the latest Wagmi version. If you have any questions or comments you can create a new discussion thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Needs Reproduction Misc: Needs Reproduction
Projects
None yet
Development

No branches or pull requests

2 participants