material-ui-dropzone -- which fork do we want?

[SailingSteve]

We might be loading a maintained, but minimally liked branch of material-ui-file-dropzone and it is throwing an error

react-dom.development.js:67 Warning: Can't perform a React state update on an unmounted component. This is a no-op, but it indicates a memory leak in your application. To fix, cancel all subscriptions and asynchronous tasks in the componentWillUnmount method. at DropzoneArea (https://localhost:3000/vendors-node_modules_mui-file- dropzone_dist_index_js.7f62992ececc56effd98.js:28255:9)

We are loading version 4.01 of https://github.com/Deckstar/mui-file-dropzone

• 11 stars
• Updated 8 months ago
• Forked from:

https://github.com/sah/material-ui-dropzone

• 1 star
• Updated two years ago
• Forked from:

https://github.com/Yuvaleros/material-ui-dropzone

• 440 stars
• at V3.50
• Updated 10 months ago

[DaleMcGrew]

Hi @SailingSteve I think switching to https://github.com/Yuvaleros/material-ui-dropzone makes sense. Thank you for the suggestion. I marked this as priority 2 since it could wait until after November unless someone has a desire to upgrade and test the change now, in favor of other higher priority features in the works. But I have no objection to the upgrade.

[eloeher]

We've upgraded to the new package and everything seems to be working as it was before, without the unmounted component error.

However, interestingly, when I now drop a photo into the dropzone, it changes the "Save photo" and "choose new election" buttons to be white with a navy hover, instead of blue with white text. All the functionality is still working, but wondering if anyone with better insight on this project's styling can give any insight on what would fix this minor UI issue.

If the UI is not an issue (or we should just open a separate issue for it) this issue is otherwise ready for a PR and close.

[DaleMcGrew]

Thank you @eloeher and @ctomasian! Yes, please feel free to submit a pull request, and we can fix the styling issue separately.