Skip to content

Commit e5fb1b3

Browse files
adamraiderAdam Raider
authored andcommitted
fix(typography): some cleanup
1 parent 151a77e commit e5fb1b3

File tree

6 files changed

+66
-53
lines changed

6 files changed

+66
-53
lines changed
Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
1-
<h1><span class="ray-text--h1">Heading 1</span></h1>
2-
<h2><span class="ray-text--h2">Heading 2</span></h1>
3-
<h3><span class="ray-text--h3">Heading 3</span></h1>
4-
<h4><span class="ray-text--h4">Heading 4</span></h1>
5-
<h5><span class="ray-text--h5">Heading 5</span></h1>
6-
<h6><span class="ray-text--h6">Heading 6</span></h1>
1+
<span class="ray-text--h1">Heading 1</span><br />
2+
<span class="ray-text--h2">Heading 2</span><br />
3+
<span class="ray-text--h3">Heading 3</span><br />
4+
<span class="ray-text--h4">Heading 4</span><br />
5+
<span class="ray-text--h5">Heading 5</span><br />
6+
<span class="ray-text--h6">Heading 6</span><br />
Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,14 @@
1+
<ol>
2+
<li>Item one</li>
3+
<li>Item two</li>
4+
<li>Item three</li>
5+
<li>
6+
Item four
7+
<ul>
8+
<li>and a one</li>
9+
<li>and a two</li>
10+
<li>and a three</li>
11+
</ul>
12+
</li>
13+
<li>Item five</li>
14+
</ol>

docs/principles/typography.md

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -67,6 +67,14 @@ Add a `<footer class="ray-blockquote__footer">` to identify a source.
6767
>
6868
</component>
6969

70+
## Lists
71+
72+
<component
73+
component="typography"
74+
variation="typography-list"
75+
>
76+
</component>
77+
7078
# Font Family
7179

7280
<p class="ray-text--body-large">Limiting font-families, a tight type scale, and content limits will keep it tight.</p>

packages/core/src/global/_base.scss

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -41,11 +41,4 @@
4141
}
4242
}
4343
}
44-
45-
ul,
46-
li {
47-
list-style-type: none;
48-
margin: 0;
49-
padding: 0;
50-
}
5144
}

packages/core/src/global/_typography.scss

Lines changed: 32 additions & 40 deletions
Original file line numberDiff line numberDiff line change
@@ -3,79 +3,76 @@
33
@mixin ray-display-1 {
44
font-size: 4rem;
55
line-height: 5.5rem;
6+
margin: 0 0 2rem;
67
}
78

89
@mixin ray-display-2 {
910
font-size: 3rem;
1011
line-height: 4rem;
12+
margin: 0 0 2rem;
1113
}
1214

1315
@mixin ray-h1 {
1416
font-size: 2.5rem;
1517
line-height: 3.5rem;
16-
margin-bottom: 1.5rem;
18+
margin: 0 0 1.5rem;
1719
}
1820

1921
@mixin ray-h2 {
2022
font-size: 2rem;
2123
line-height: 2.75rem;
22-
margin-bottom: 1.5rem;
24+
margin: 0 0 1.5rem;
2325
}
2426

2527
@mixin ray-h3 {
2628
font-size: 1.5rem;
2729
line-height: 2.25rem;
28-
margin-bottom: 1rem;
30+
margin: 0 0 1rem;
2931
}
3032

3133
@mixin ray-h4 {
3234
font-size: 1.25rem;
3335
line-height: 2rem;
34-
margin-bottom: 1rem;
36+
margin: 0 0 1rem;
3537
}
3638

3739
@mixin ray-h5 {
3840
font-size: 1rem;
3941
line-height: 1.75rem;
40-
margin-bottom: 1rem;
42+
margin: 0 0 1rem;
4143
}
4244

4345
@mixin ray-h6 {
4446
font-size: 0.875rem;
4547
line-height: 1.5rem;
46-
margin-bottom: 1rem;
48+
margin: 0 0 1rem;
4749
}
4850

4951
@mixin ray-body {
5052
font-size: 1rem;
5153
line-height: 1.75rem;
54+
margin: 0 0 1rem;
5255
}
5356

5457
@mixin ray-body-large {
5558
font-size: 1.25rem;
5659
line-height: 2rem;
60+
margin: 0 0 1rem;
5761
}
5862

5963
@mixin ray-body-small {
6064
font-size: 0.875rem;
6165
line-height: 1.5rem;
66+
margin: 0 0 0.75rem;
6267
}
6368

6469
@mixin ray-body-x-small {
6570
font-size: 0.75rem;
6671
line-height: 1.25rem;
72+
margin: 0 0 0.5rem;
6773
}
6874

6975
@include exports('ray-typography') {
70-
h1,
71-
h2,
72-
h3,
73-
h4,
74-
h5,
75-
h6 {
76-
margin: 0;
77-
}
78-
7976
.#{$ray-class-prefix}text--display-1 {
8077
@include ray-display-1;
8178
}
@@ -142,17 +139,6 @@
142139
@include ray-h6;
143140
}
144141

145-
p {
146-
font-weight: 400;
147-
margin: 0;
148-
}
149-
150-
p {
151-
&:not(:last-child) {
152-
margin-bottom: 1rem;
153-
}
154-
}
155-
156142
.#{$ray-class-prefix}text--body-large {
157143
@include ray-body;
158144

@@ -193,12 +179,32 @@
193179
font-weight: 400;
194180
font-family: $ray-font-stack-mono;
195181
color: $ray-color-text-medium;
182+
margin: 0;
196183

197184
&::before {
198185
content: '\2014\00A0';
199186
}
200187
}
201188

189+
ul,
190+
ol {
191+
margin: 0.75rem 0;
192+
padding-left: 2rem;
193+
194+
ul,
195+
ol {
196+
margin: 0 0 0.25rem 0;
197+
}
198+
}
199+
200+
ul li {
201+
list-style-type: circle;
202+
}
203+
204+
ol {
205+
list-style-type: decimal;
206+
}
207+
202208
.#{$ray-class-prefix}running-text {
203209
h1,
204210
h2,
@@ -241,20 +247,6 @@
241247
@extend .#{$ray-class-prefix}text--body-small;
242248
}
243249

244-
ul,
245-
ol {
246-
margin: 0.75rem 0;
247-
padding-left: 2rem;
248-
}
249-
250-
ul li {
251-
list-style-type: circle;
252-
}
253-
254-
ol li {
255-
list-style-type: decimal;
256-
}
257-
258250
blockquote {
259251
@extend .#{$ray-class-prefix}blockquote;
260252
}

packages/docs-app/src/components/SideNav/side-nav.scss

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,12 @@
2424
transition: left 0.15s ease;
2525
padding: 4rem 0;
2626

27+
ul {
28+
list-style-type: none;
29+
margin: 0;
30+
padding: 0;
31+
}
32+
2733
&--open {
2834
left: 0;
2935
}

0 commit comments

Comments
 (0)