Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(checkbox): squishing on small containers #169

Merged
merged 2 commits into from
Jul 11, 2019
Merged

Conversation

cmugla
Copy link

@cmugla cmugla commented Jul 10, 2019

BEFORE:
Screen Shot 2019-07-10 at 5 06 07 PM

AFTER:
Screen Shot 2019-07-10 at 7 04 45 PM

@cmugla cmugla requested a review from a team as a code owner July 10, 2019 23:04
@@ -25,7 +25,7 @@
content: '';
background-color: $ray-color-white;
border: $ray-radio-checkbox-border-width solid $ray-color-black;
width: $ray-radio-checkbox-size;
min-width: $ray-radio-checkbox-size;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we also set width here? to really make sure that its always a square

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fo sho

@cmugla cmugla requested a review from adamraider July 11, 2019 16:39
@cmugla cmugla merged commit 2efd725 into master Jul 11, 2019
@delete-merged-branch delete-merged-branch bot deleted the cg/fix-checkbox branch July 11, 2019 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants