Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(colors): add 03 gray #8

Merged
merged 5 commits into from
Apr 30, 2019
Merged

fix(colors): add 03 gray #8

merged 5 commits into from
Apr 30, 2019

Conversation

adamraider
Copy link
Contributor

@adamraider adamraider commented Apr 17, 2019 •
edited
Loading

fix #2

  • removes $ray-color-gray-02

@adamraider adamraider requested a review from cmugla as a code owner April 17, 2019 15:14
@cmugla
Copy link

cmugla commented Apr 17, 2019

Wondering if this is a system color change or a new color, specifically because 02 and 03 are so similar.... if it is a system change, we may want to remove -02 and have it be a breaking change, so people can't use that color anymore. Thoughts?

@adamraider
Copy link
Contributor Author

adamraider commented Apr 18, 2019 •
edited
Loading

Will need to remove gray-02 from the system. This will be a breaking change.

cmugla
cmugla approved these changes Apr 30, 2019
View reviewed changes
Copy link

@cmugla cmugla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fancy

@adamraider adamraider merged commit 7637594 into master Apr 30, 2019
@adamraider adamraider deleted the raid/new-gray branch April 30, 2019 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmugla cmugla cmugla approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

GLOBAL > Grey color change
2 participants
@adamraider @cmugla