-
-
Notifications
You must be signed in to change notification settings - Fork 781
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
font kerning / rendering sometimes breaks #1931
Comments
Try a more recent nightly build? Harfbuzz (the font shaping library that performs this function) has been updated since that last release and it may have improved things |
Looks like the latest nightly AppImage does not work for some reason
This is on Fedora 35 on Wayland. I'll see if I can build myself and get that working. |
A local build of an AppImage worked, so I'll try it out for the next couple days and see if I still see the issue. Not sure what's going on with the pre-packaged AppImage; should I file another bug for this? |
re: AppImage, I've had a few reports that they aren't working on some distros. It couldn't hurt to open an issue specifically for that. |
I haven't seen this happen in a few days, so the harfbuzz upgrade must have fixed it. Thanks! |
Actually, I'm sorry, I spoke too soon. I just saw it happen now. Here's a new screenshot with Good: Bad: It's more subtle now than it was, but it's definitely still there. You can see it in particular on the |
Can you try experimenting with: https://wezfurlong.org/wezterm/config/font-shaping.html |
It may also be helpful to try:
to see what the shaper is telling wezterm to do |
Sorry, what things should I experiment with? That link looks like stuff for adding otf features? Here's the output of that
|
Something else to try:
and:
which should compare how it shapes "all" with how it shapes "url". You can see a basic rendering of that text inline in the terminal using:
but please redirect each of those to a file (instead of piping through imgcat) and attach to this issue; that will help to determine the data from the shaper looks good. |
Here are the png's. Nothing seems wrong when they are freshly rendered. It seems to happen on its own while typing sometimes. I've noticed since making this issue that it seems to become triggered while typing. Sometimes after typing some character combinations, the letters shift around, and don't go back to where they should be. |
Can you try setting |
This issue has been automatically closed because there has been no response to our request for more information from the original author. With only the information that is currently in the issue, we don't have enough information to take action. Please reach out if you have or find the answers we need so that we can investigate further. |
Oh I'm sorry, I lost track of this. I did not try the hinting setting above yet, but I do think it's worth noting that I've been using a build that I made on my local laptop for a couple weeks, and I haven't seen the issue happen. I'm guessing maybe this could be an issue with some lib that's bundled with the AppImage? Maybe one that's incompatible with the one in use on Ubuntu? |
OK, then let's close this out. If you see it again, please try changing that hinting setting, and let me know how it goes! |
I've been trying out the latest release using the fedora .rpm build, and this issue still happens, even with the no hinting setting you suggested above. |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
What Operating System(s) are you seeing this problem on?
Linux Wayland
WezTerm version
20220408-101518-b908e2dd AppImage
Did you try the latest nightly build to see if the issue is better (or worse!) than your current version?
No, and I'll explain why below
Describe the bug
I've noticed recently that sometimes the font rendering will suddenly get messed up, misaligning characters inside their boxes. For example, this is with Pragmata Pro, and how the font should look:
And seemingly at random times, it will suddenly look like this:
It seems as if the glyphs lose their correct position somehow. I'm not a font expert, but I'm not sure if this might have something to do with kerning?
To add to the strangeness, it seems to be isolated to a specific window and/or tmux attachment. If I open a new window, the issue is not present. In the example above, when I have a window doing this with the fonts, if I detach from tmux, the font renders fine again. So I thought maybe somehow this was a tmux issue. But if I attach to the same session in a different window, it doesn't have the problem. Other terminals like Alacritty and Gnome Terminal don't have this problem.
To Reproduce
Hard to say, since it seems to happen randomly.
Configuration
Expected Behavior
No response
Logs
10:20:18.541 ERROR wezterm_gui::termwindow > PaneOutput: wanted mux_window_id=1 from mux, but was not found, cancel mux subscription
11:22:32.164 INFO wezterm_gui::termwindow > Ding! (this is the bell) in pane 2
11:22:32.164 INFO wezterm_gui::termwindow > Ding! (this is the bell) in pane 2
11:22:32.164 INFO wezterm_gui::termwindow > Ding! (this is the bell) in pane 2
11:22:32.164 INFO wezterm_gui::termwindow > Ding! (this is the bell) in pane 2
11:49:42.892 INFO wezterm_gui::termwindow > Ding! (this is the bell) in pane 2
11:49:42.892 INFO wezterm_gui::termwindow > Ding! (this is the bell) in pane 2
11:49:42.892 INFO wezterm_gui::termwindow > Ding! (this is the bell) in pane 2
11:49:42.892 INFO wezterm_gui::termwindow > Ding! (this is the bell) in pane 2
11:57:43.023 WARN wezterm_term::terminalstate > unhandled DecPrivateMode ResetDecPrivateMode(Unspecified(1005))
11:57:43.023 WARN wezterm_term::terminalstate > unhandled DecPrivateMode ResetDecPrivateMode(Unspecified(7727))
11:58:06.370 WARN wezterm_term::terminalstate > unhandled DecPrivateMode ResetDecPrivateMode(Unspecified(1005))
11:58:06.382 WARN wezterm_term::terminalstate > unhandled DecPrivateMode SetDecPrivateMode(Unspecified(7727))
11:58:06.383 WARN wezterm_term::terminalstate > unhandled DecPrivateMode SetDecPrivateMode(Unspecified(7727))
12:01:51.558 ERROR window::os::wayland::copy_and_paste > Offer dnd_action None
12:01:51.559 ERROR window::os::wayland::copy_and_paste > Offer source_actions Copy | Move | Ask
12:02:11.716 ERROR window::os::wayland::copy_and_paste > Offer dnd_action None
12:02:11.716 ERROR window::os::wayland::copy_and_paste > Offer source_actions Copy | Move | Ask
Anything else?
No response
The text was updated successfully, but these errors were encountered: