fix: only change stable row offset if screen has scrollback #6099
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wez
added a commit
that referenced
this pull request
Sep 14, 2024
We should avoid nudging the scrollback position when there is no scrollback allowed in this other case as well. refs: #6099
|
Thanks! |
loops
added a commit
to loops/wezterm
that referenced
this pull request
Sep 27, 2024
@tbung fixed a scrolling bug in wezterm#6099. This patch just adds some tests and takes care of a couple corner cases that still remained with region scrolling.
loops
added a commit
to loops/wezterm
that referenced
this pull request
Sep 28, 2024
@tbung fixed a scrolling bug in wezterm#6099. This patch just adds some tests and takes care of a couple corner cases that still remained with region scrolling.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed, that in specific circumstances some lines are moving in a way they are not supposed to in alternate screen mode. Particularly noticeable in neovim.
wezterm_bug_demo.mp4
Turns out, when scrolling in a mux window, the viewport is moved down even if there is not supposed to be a scrollback (like in altenate screen mode). I added a check in the corresponding scroll method.
Together with #5981 this was part of the issues described in #4607.