Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does not work on Python 3 #7

Open
whaleygeek opened this issue Aug 30, 2014 · 2 comments
Open

Does not work on Python 3 #7

whaleygeek opened this issue Aug 30, 2014 · 2 comments

Comments

@whaleygeek
Copy link
Owner

I have not made this Python 3 safe yet. Most of the imports for things like thread etc are done, but the import rules changed in Python 3 for sub packages and parent packages, and this needs making Python 3 safe.

The code is only tested on Python 2.7 at the moment.

@whaleygeek
Copy link
Owner Author

As per issue 8, I hope to do some work on this before the end of 2014

@whaleygeek
Copy link
Owner Author

Well, I never did get round to doing this, and it's now 2017!

I spoke to @martinohanlon and we might update this to Python3 to support mods for the new edition of AdventuresInMinecraft.

The issue really is to bring in the latest PySerial 3.x and change the API so it handles unicode correctly. If you look at the bitio project, this does just that and it works fine, so really all we need to do is retro-fit those changes.

Also note that in the bitio project the portscan is a bit more modular, being a sub package inside the 'microbit' folder - it might be nice to also cherry pick those changes over to here too.

Package imports in bitio are also sorted for both python 2 and python 3

So, this would be the comparison point to cherrypick from...

https://github.com/whaleygeek/bitio

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant