redirect doesn't cancel or consume current response

[ronag]

Even though a server shouldn't send a body with a redirect response, it is still possible. The way the spec is defined we have a deadlock here if the connection is re-used where the redirect response body is waiting to be consumed but we discard the reference and start a new request (mainFetch). We should probably consume/cancel/abort current response body before calling mainFetch again.

We avoid the same issue with 427 by setting forceNewConnection in httpNetworkOrCacheFetch.

[annevk]

I'm not sure how much we want to say about this, though perhaps we should add some wording. A lot of this depends on the HTTP version.

[ronag]

I think you want to cancel/end/abort the response stream in some way regardless of http version? Maybe just write "cancel response stream" and leave what that means as an implementation detail?

[annevk]

Step 8 of https://fetch.spec.whatwg.org/#http-fetch does something like that. #637 is about making that version-agnostic.

This request is slightly different I suppose in that you are asking for mandatory behavior which is not unreasonable. We'd need everyone to agree on what that behavior should be though.

[ronag]

Ah, you mean:

If actualResponse’s status is not 303, request’s body is not null, and the connection uses HTTP/2, then user agents may, and are even encouraged to, transmit an RST_STREAM frame.

Not sure why the "status is not 303" pre-condition exists? A 303 response may also contain a body if the server doesn't follow spec.

[ronag]

In terms of "needs implementer interest" I can add Node to that list. I'm working on implementing fetch for nodejs through https://github.com/nodejs/undici.

[domenic]

The WHATWG working mode is about implementing specs in browser engines, so we need multiple browser engines interested in such a thing.

[ronag]

I see. Was hoping Node could be included in the list as an "engine". I assume then that WHATWG has limited (if any) involvement in Node.

[domenic]

Yeah, you can learn more about the WHATWG here: https://whatwg.org/faq#what-is-the-whatwg

[ronag]

Likewise the 407 case does not cleanup the active response.