Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

URL parser called with byte sequence #843

Open
jyasskin opened this issue Nov 30, 2018 · 2 comments
Open

URL parser called with byte sequence #843

jyasskin opened this issue Nov 30, 2018 · 2 comments
Labels
needs tests Moving the issue forward requires someone to write tests topic: http

Comments

@jyasskin
Copy link
Member

https://url.spec.whatwg.org/#concept-url-parser takes a string, but https://fetch.spec.whatwg.org/#concept-http-fetch calls it with the value of the Location header, a byte sequence.
@annevk
Copy link
Member

annevk commented Dec 3, 2018

Thanks, this probably requires a number of tests as I suspect some browsers to UTF-8 decode. And Location parsing in general is in need of a greater number of tests and a rewrite to use the new header infrastructure.

@annevk annevk added needs tests Moving the issue forward requires someone to write tests topic: http labels Dec 3, 2018
@annevk
Copy link
Member

annevk commented Dec 3, 2018

(See also #814.)

@jyasskin jyasskin mentioned this issue Dec 4, 2018
Merged
@annevk annevk mentioned this issue Jan 30, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
needs tests Moving the issue forward requires someone to write tests topic: http
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jyasskin @annevk