Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add back XMLDocument.prototype.load in Gecko compatibility mode #1530

Closed
domenic opened this issue Jul 9, 2016 · 11 comments
Closed

Add back XMLDocument.prototype.load in Gecko compatibility mode #1530

domenic opened this issue Jul 9, 2016 · 11 comments
Assignees
Labels
compat Standard is not web compatible or proprietary feature needs standardizing needs compat analysis

Comments

@domenic
Copy link
Member

domenic commented Jul 9, 2016

Opening this to track the discussions in #1478 (comment) so I don't forget. We'll want to add some links to the Bugzilla bugs @bzbarsky referenced explaining what's going on here and stating something like "as of 2011, this was necessary; if anyone using a Gecko UA string has evidence that it is not, let us know."

We could still make XMLDocument === Document (see whatwg/dom#278) and just add load to Document, I believe.

@domenic domenic self-assigned this Jul 9, 2016
@zcorpan
Copy link
Member

zcorpan commented Jul 9, 2016

It may not be web compatible to have load on Document. Don't do that ☺

@annevk
Copy link
Member

annevk commented Jul 18, 2016

Yeah, I don't think it is. That's why we added the distinction. Perhaps it might be in non-Gecko browsers? Ugh, this all sucks.

@foolip
Copy link
Member

foolip commented Sep 21, 2016

When I looked closer in whatwg/dom#308 (comment) it didn't look like problem with the Sarissa library from 2011 actually depended on XMLDocument.prototype.load. It could still be needed for some other reason, but how to find out?

@foolip
Copy link
Member

foolip commented Sep 28, 2016

I've tried to summarize everything I could find about document interfaces here:
https://gist.github.com/foolip/103963a1ae8598d2baedd296f4a1bf4c

Since the discussion is spread out, I arbitrarily suggest discussing the larger issue in whatwg/dom#221

@zcorpan zcorpan added compat Standard is not web compatible or proprietary feature needs standardizing needs compat analysis labels Sep 1, 2018
@ExE-Boss
Copy link

Firefox has bug 332175 open to remove this, and no other engine implements this, so WebCompat breakage as a result of closing this will probably be virtually non‑existent.

@bzbarsky
Copy link
Contributor

@ExE-Boss What makes you say that there won't be webcompat breakage, exactly? People were using this together with UA-sniffing, last I checked. And the bug you reference was opened 12 years ago, and explains all that. Do you have any actual data showing there won't be breakage?

@annevk
Copy link
Member

annevk commented Sep 21, 2018

That's still a relatively high absolute number and depending on the breakage might not be acceptable. It's perhaps worth trying again, but that's not good enough data to suggest Firefox is going to remove this to standards forums.

@foolip
Copy link
Member

foolip commented Sep 21, 2018

Yep, 0.003% is a small number, but when we remove things from Chrome, that's still large enough that we want to understand what the breakage would look like. If it would throw an exception in a script that critical to the functioning of the page, for example, then that wouldn't be a negligible problem.

@zcorpan
Copy link
Member

zcorpan commented May 28, 2019

load and async have been removed in Firefox 68
https://bugzilla.mozilla.org/show_bug.cgi?id=332175
https://bugzilla.mozilla.org/show_bug.cgi?id=1328138

Both of these are tested in dom/historical.html

I think we can close this issue.

@zcorpan zcorpan closed this as completed May 28, 2019
@bzbarsky
Copy link
Contributor

load and async have been removed in Firefox 68

Note that this has not shipped and we have no idea whether this is web-compatible yet...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compat Standard is not web compatible or proprietary feature needs standardizing needs compat analysis
Development

No branches or pull requests

6 participants