Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add workflow dispatch support #68

Merged
merged 1 commit into from
Jan 11, 2024
Merged

Add workflow dispatch support #68

merged 1 commit into from
Jan 11, 2024

Conversation

domenic
Copy link
Member

@domenic domenic commented Jan 11, 2024

This should allow us to manually trigger builds. Closes #67.

This should allow us to manually trigger builds. Closes #67.
@domenic domenic requested a review from annevk January 11, 2024 07:44
on:
pull_request:
branches:
- main
push:
branches:
- main
workflow_dispatch:
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wasn't clear how to write this but based on the example at https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#using-data-from-the-triggering-workflow which uses pull_request: with no subkeys, I think this is right.

Copy link
Member

@annevk annevk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe @foolip can double check? I think he set this up originally. Otherwise we can test it out with one standard first before deploying it everywhere. I guess we'll do that either way.

Copy link
Member

@foolip foolip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is indeed how to do it. I think workflow_dispatch: {} would also work, but I don't think it's better really.

@foolip foolip merged commit c563cab into main Jan 11, 2024
@foolip foolip deleted the workflow-dispatch branch January 11, 2024 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Add workflow_dispatch to build.yml?
3 participants