Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider using AggregateError for tee() cancelation reasons #1134

Open
domenic opened this issue Jun 4, 2021 · 1 comment
Open

Consider using AggregateError for tee() cancelation reasons #1134

domenic opened this issue Jun 4, 2021 · 1 comment

Comments

@domenic
Copy link
Member

domenic commented Jun 4, 2021

Currently we put the cancelation reasons into an array. But since tee() was invented, AggregateError has shipped, which is made for this purpose.

I'm not sure this is worth the breaking change (especially since it'd be pretty hard to measure usage of the array form), but I thought it'd be worth considering...

@MattiasBuelens
Copy link
Collaborator

I'm leaning towards "yes". So far, the only time where I was interested in the array of errors from a tee'd stream was when I wanted to convert it into an AggregateError myself. I'd be happy if I can remove that hack out of my own code. 😛

But indeed, it might be difficult to know if/how this is being used in the wild. 😕

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants