Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace cdrdao and python-cddb with libcdio functions #162

Open
45054 opened this issue May 19, 2017 · 4 comments
Open

replace cdrdao and python-cddb with libcdio functions #162

45054 opened this issue May 19, 2017 · 4 comments
Labels
Feature New feature Needed: discussion More discussion needed before anything can be done (or still no agreement has been reached) On Hold Waiting for other actions
Milestone

Comments

@45054
Copy link

45054 commented May 19, 2017

As we already depend on pycdio and eventually on libcdio-paranoia, the internal libcdio functions could be used as a replacement for cdrdao and python-cddb. This would reduce the amount of dependencies on unmaintained libraries.

The command cd-info could, for example, be used to extract the TOC, CD-TEXT and CDDB info.

@MerlijnWajer
Copy link
Collaborator

libcdio is not a proper replacement on other platforms. I've found that in particular on OS X, cdrdao interfaces correctly with CDs, whereas libcdio simply cannot perform certain actions. (I'll have to dig to figure out which ones). But why replace cdrdao when it works fine?

@45054
Copy link
Author

45054 commented May 19, 2017

Mainly to reduce the list of dependencies. Also cdrdao seems to be the source of some bugs ( #145 and #72 ) and is unmaintained or at least hasnt seen a release in 8 years.

If libcdio prevents cross plattform compatibility, any change should be postponed, of course, until those issues are fixed.

@MerlijnWajer
Copy link
Collaborator

I would be surprised if replacing it would lead to less bugs, but it may be worth it. Are you sure it fully replaces CDRDAO? I thought CDRDAO had some special way to read the TOC, e.g. to detect hidden tracks and such. There's a reason it reads the whole CD, right...?

@RecursiveForest
Copy link
Contributor

I like the idea of at least having another method (even if it only works on some platforms) of checking the toc. I wouldn't wholesale replace cdrdao.

@JoeLametta JoeLametta added this to the backlog milestone Apr 6, 2018
@JoeLametta JoeLametta added Feature New feature On Hold Waiting for other actions Needed: discussion More discussion needed before anything can be done (or still no agreement has been reached) and removed idea labels Nov 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature New feature Needed: discussion More discussion needed before anything can be done (or still no agreement has been reached) On Hold Waiting for other actions
Projects
None yet
Development

No branches or pull requests

4 participants