Whipper gives up even if 5th rip attempt is successful

[the-confessor]

I haven't run into this condition yet, but I noticed this looking at the code.

It appears that if the first 4 attempts to rip a track fail, then the 5th attempt succeeds, Whipper would abort the operation anyway.

From cd.py:

                if tries == MAX_TRIES:
                    logger.critical('giving up on track %d after %d times',
                                    number, tries)
                    raise RuntimeError(
                        "track can't be ripped. "
                        "Rip attempts number is equal to 'MAX_TRIES'")

Should the condition actually be tries >= MAX_TRIES?

[ABCbum]

Yeah, i think just move the block

if tries == MAX_TRIES:
  ......

in to the while loop before it should solve the problem since if the rip attempt is successful then it will break the loop right away. Right ?

[the-confessor]

Yes something like that would also work. As long as it doesn't give up when the most recent attempt to rip the track is successful.

[JoeLametta]

@the-confessor Thanks for reporting this issue.
The bug should have been fixed in commit caa2c8b.