Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Whipper configuration file: cover_art option does nothing #465

Closed
h1nk opened this issue Feb 8, 2020 · 2 comments
Closed

Whipper configuration file: cover_art option does nothing #465

h1nk opened this issue Feb 8, 2020 · 2 comments
Labels
Accepted Accepted issue on our roadmap Bug Generic bug: can be used together with more specific labels Design Design or UX/UI related
Milestone

Comments

@h1nk
Copy link

h1nk commented Feb 8, 2020

It seems that there's no such cover_art configuration directive for the [whipper.cd.rip] section?

I've tried the following in my user configuration file, but no album art images are produced:

[whipper.cd.rip]
cover_art = complete
@ABCbum
Copy link
Contributor

ABCbum commented Feb 8, 2020

Hi, could you provide a little bit more metadata about the disc ? Since it is possible that your disc doesn't have a cover art on Cover Art Archive.

@JoeLametta JoeLametta added Accepted Accepted issue on our roadmap Bug Generic bug: can be used together with more specific labels Design Design or UX/UI related labels Feb 9, 2020
@JoeLametta JoeLametta added this to the 1.0 milestone Feb 9, 2020
@JoeLametta
Copy link
Collaborator

Thanks for reporting this issue. This happens because of an inconsistent naming: the config file should understand an option named fetch_cover_art.
Fixed this (adopt consistent naming, config should understand cover_art) in commit 6fd7a78.

@JoeLametta JoeLametta changed the title cover_art configuration directive Whipper configuration file: cover_art option does nothing Feb 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Accepted Accepted issue on our roadmap Bug Generic bug: can be used together with more specific labels Design Design or UX/UI related
Projects
None yet
Development

No branches or pull requests

3 participants