You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Add less verbose and clear error handling when whipper cd is run without a drive offset configured
Background
When I first used whipper, I didn't realize I needed the drive offset first. There is a large, mostly unhelpful stacktrace where the ValueError is raised. Suppressing the stdout to a single-line error would be a small quality-of-life enhancement for my logging.
Details
Reproduced the first time I ran whipper:
whipper cd -d /dev/sr1 rip
Traceback (mostrecentcalllast):
File"/usr/bin/whipper", line11, in<module>load_entry_point('whipper==0.9.0', 'console_scripts', 'whipper')()
File"/usr/lib64/python3.7/site-packages/whipper/command/main.py", line42, inmaincmd=Whipper(sys.argv[1:], os.path.basename(sys.argv[0]), None)
File"/usr/lib64/python3.7/site-packages/whipper/command/basecommand.py", line117, in__init__self.optionsFile"/usr/lib64/python3.7/site-packages/whipper/command/basecommand.py", line117, in__init__self.optionsFile"/usr/lib64/python3.7/site-packages/whipper/command/basecommand.py", line104, in__init__self.handle_arguments()
File"/usr/lib64/python3.7/site-packages/whipper/command/cd.py", line304, inhandle_argumentsraiseValueError("Drive offset is unconfigured.\n"ValueError: Driveoffsetisunconfigured.
Pleaseinstallpycdioandrun'whipper offset find'todetectyourdrive's offset or set it manually in the configuration file. It can also be specified at runtime using the '--offset=value' argument
Just the last line is helpful for me as an end-user.
Outcome
Easier to read and understand error logs
Produces more readable, less verbose system logs
The text was updated successfully, but these errors were encountered:
👋 Thanks for opening your first issue here! If you're reporting a 🐞 bug, please make sure you include steps to reproduce it. We get a lot of issues on this repo, so please be patient and we will get back to you as soon as we can.
To help make it easier for us to investigate your issue, please follow the contributing instructions.
Summary
Add less verbose and clear error handling when
whipper cd
is run without a drive offset configuredBackground
When I first used
whipper
, I didn't realize I needed the drive offset first. There is a large, mostly unhelpful stacktrace where theValueError
is raised. Suppressing thestdout
to a single-line error would be a small quality-of-life enhancement for my logging.Details
Reproduced the first time I ran
whipper
:whipper cd -d /dev/sr1 rip
Just the last line is helpful for me as an end-user.
Outcome
The text was updated successfully, but these errors were encountered: