Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

read-toc information follow-up #521

Open
Forage opened this issue Dec 27, 2020 · 2 comments
Open

read-toc information follow-up #521

Forage opened this issue Dec 27, 2020 · 2 comments
Labels
Accepted Accepted issue on our roadmap Design Design or UX/UI related Needed: discussion More discussion needed before anything can be done (or still no agreement has been reached)

Comments

@Forage
Copy link
Contributor

Forage commented Dec 27, 2020

Hi,

As a follow-up of #299 I'd like to suggest making the provided info a bit more useful.

With whipper cd info we get a list like the following

Track 1 finished, found 122 Q sub-channels with CRC errors
Track 2 finished, found 65 Q sub-channels with CRC errors
Track 3 finished, found 51 Q sub-channels with CRC errors
Track 4 finished, found 257 Q sub-channels with CRC errors
Track 5 finished, found 78 Q sub-channels with CRC errors

But it doesn't actually tell us what has finished.
The same is shown during the ripping stage with whipper cd rip, which would imply the ripping of those tracks has finished, while it hasn't even actually began yet.

A simple line stating Reading disc TOC, or better yet Analysing disc TOC due to the time it takes and the actions it actually does, before the results would already help.

Especially because the TOC reading takes quite some time for some reason, it would be great to have it actually provide more useful information.
Normally you'd be more interested in the more practical info like number of tracks, their lengths and possibly it's ISRC, etc. than the more technical stuff like number of Q sub-channels. Also reading with CRC errors does not look very promising. If we are not actually dealing with errors here whipper shouldn't mention it either.

It gives a lot of info like the matching MusicBrainz releases, which is good and very helpful, but it seems to me that what's physically on the disc in front of us has more priority.

Would it be possible to give us a little table of tracks, length, (possible) read title, (possible) MB title, (possible) read ISRC, etc at the aforementioned stages?

@github-actions
Copy link

👋 Thanks for opening your first issue here! If you're reporting a 🐞 bug, please make sure you include steps to reproduce it. We get a lot of issues on this repo, so please be patient and we will get back to you as soon as we can.

To help make it easier for us to investigate your issue, please follow the contributing instructions.

@JoeLametta JoeLametta added Accepted Accepted issue on our roadmap Design Design or UX/UI related Needed: discussion More discussion needed before anything can be done (or still no agreement has been reached) labels Jan 31, 2021
@mtdcr
Copy link
Contributor

mtdcr commented Mar 24, 2021

Also reading with CRC errors does not look very promising. If we are not actually dealing with errors here whipper shouldn't mention it either.

I think the number of CRC errors is useful information, because it lets you estimate the condition a CD is in. Maybe it would be useful to annotate it with the track length and the number of CRC errors per minute.

While at it, IIRC, whipper does not print any status line for tracks without CRC errors. If you're used to seeing these lines, ripping a CD in very good condition may likely be confusing, because you don't observe progress.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Accepted Accepted issue on our roadmap Design Design or UX/UI related Needed: discussion More discussion needed before anything can be done (or still no agreement has been reached)
Projects
None yet
Development

No branches or pull requests

3 participants