.TOC file frustration when attempting to burn

[chuckufarley73]

My apologies in advance if this request is not entirely representative of a Whipper related issue and more attributable to user ignorance..

For the first time ever since using Whipper, I recently set about burning files ripped from a CD with Whipper, by using cdrdao and referencing the generated .toc file, given Brasero/k3b bork.

I was unsuccessful, receiving a notification re cdrdao only expecting to find one toc file, but what struck me as interesting was that the tracks listed in the .toc were each named 'data', rather than the name of the tracks that were identified during the rip.

I had converted these to .wav from .flac post-rip but I'm curious whether I may be correct in thinking that a) cdrdao will only reconcile/burn a single image file as opposed to individual tracks, and b) may refuse to accept to files that reflect 'non-compliant'/Red Book gaps?

Again apologies that this doesn't in any sense represent any issue in regard to Whipper, I'm posting chiefly as I'm curious as to how one typically would burn ripped files using the toc file produced to help with that purpose.

Many thanks.

[github-actions]

👋 Thanks for opening your first issue here! If you're reporting a 🐞 bug, please make sure you include steps to reproduce it. We get a lot of issues on this repo, so please be patient and we will get back to you as soon as we can.

To help make it easier for us to investigate your issue, please follow the contributing instructions.

[BBaoVanC]

It works perfectly if you concatenate all of the flacs to a single data.wav (i.e. with sox: sox '01. SongName1.flac' '02. SongName2' data.wav) without adding gaps in between (the gaps are embedded in the flacs already, at the end of each file).

I can't confirm why whipper uses data.wav instead of the individual flacs, but I suspect it might be because cdrdao straight up doesn't handle flacs properly¹.

Footnotes

1. I just discovered this on my own, because of warnings with my own TOC I was making:
   WARNING: Length of file "01. Rush - Tom Sawyer.flac" is not a multiple of sample size (4). TOC TYPE: CD_DA

   Turns out they forgot to add FLAC to the else if in TrackData::audioDataLength which would exit saying that the flac needs file conversion and is not just uncompressed samples. ↩

[MerlijnWajer]

I don't know if this helps, but I wrote this some years ago to turn morituri/whipper ripped CDs back into burnable CDs (it assumed archive.org items but that doesn't have to be the case of course, juts change up the commands slightly). You would start at the "Create Toc File" part: https://git.archive.org/archivecd/cd-burn

[BBaoVanC]

I don't know if this helps, but I wrote this some years ago to turn morituri/whipper ripped CDs back into burnable CDs (it assumed archive.org items but that doesn't have to be the case of course, juts change up the commands slightly). You would start at the "Create Toc File" part: https://git.archive.org/archivecd/cd-burn

You don't need a tool to create a toc, since whipper already makes one. The issue is just that the toc is written with the assumption of a singular data.wav

All you have to do is concatenate all the flacs from whipper's output back-to-back into a single file named data.wav (i.e. with ffmpeg,sox, or even Audacity). Then cdrdao (or whatever burner tool you want) should work with whipper's generated TOC file.