Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Propagate error through Result from Country::id(&self) #56

Open
rubdos opened this issue May 31, 2023 · 0 comments · May be fixed by #74
Open

Propagate error through Result from Country::id(&self) #56

rubdos opened this issue May 31, 2023 · 0 comments · May be fixed by #74
Labels
bug
Milestone
0.4

Comments

@rubdos
Copy link
Member

rubdos commented May 31, 2023

Whereas #54 avoids a panic when the country id is unparsable, it would be better to propagate this error to the caller. This is a breaking change, and we currently don't want to break the main branch.
@rubdos rubdos added the bug label May 31, 2023
@rubdos rubdos added this to the 0.4 milestone May 31, 2023
@rubdos rubdos linked a pull request Jul 7, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
0.4
Development

Successfully merging a pull request may close this issue.

Return unparseable country code as error instead of silent failure whisperfish/rust-phonenumber
1 participant
@rubdos