Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make cloud.instance_info.status an enum #4973

Closed
owenniles opened this issue Dec 22, 2021 · 2 comments
Closed

Make cloud.instance_info.status an enum #4973

owenniles opened this issue Dec 22, 2021 · 2 comments
Labels
cleanup Cleaning up and organizing our repositories good-first-issue Good for newcomers priority-5-low #5 Priority - Something that should happen eventually

Comments

@owenniles
Copy link
Contributor

See #4972

@owenniles owenniles added cleanup Cleaning up and organizing our repositories good-first-issue Good for newcomers priority-5-low #5 Priority - Something that should happen eventually python labels Dec 22, 2021
@philippemnoel
Copy link
Collaborator

@owenniles @MauAraujo is this still relevant even though we're removing most of the webserver?

@MauAraujo
Copy link

I will close this issue since we will no longer use enums on the new database schema. While having a lot of benefits, enums are still somewhat unsupported on the libraries we use for interacting with the database. In order for them to work, we need to do some workarounds.

For example, the Hasura client only supports enums if they are declared in the public schema, and in order for them to work we need to create go types with the exact same name, which results in unidiomatic code. The db driver also has trouble when encoding/decoding custom types, as can be seen here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Cleaning up and organizing our repositories good-first-issue Good for newcomers priority-5-low #5 Priority - Something that should happen eventually
Projects
None yet
Development

No branches or pull requests

3 participants