Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs error #181

Closed
skornev opened this issue Jun 16, 2015 · 5 comments
Closed

Docs error #181

skornev opened this issue Jun 16, 2015 · 5 comments

Comments

@skornev
Copy link

skornev commented Jun 16, 2015

Options value

  • previous_message (Previous) should be prev_message
@stof
Copy link
Contributor

stof commented Jun 16, 2015

Can you send a pull request with the fix ? This would give you attribution on the commit for that fix

@skornev
Copy link
Author

skornev commented Jul 14, 2015

I have sent a pull request.

@smoench
Copy link

smoench commented Sep 8, 2015

@skornev @stof documentation has no error.

The Problem was introduced with the TwitterBootstrapTemplate. The BootstrapTemplate uses prev_message as key in $defaultOptions, but DefaultTemplate uses previous_message.

@cezzre
Copy link

cezzre commented May 22, 2017

Solved.

@cezzre cezzre closed this as completed May 22, 2017
@sampart
Copy link
Collaborator

sampart commented May 23, 2017

To clarify, this is fixed in #230

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@smoench @stof @sampart @skornev @cezzre