Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Solve Rubocop warnings #250

Closed
nunosilva800 opened this issue Oct 6, 2017 · 5 comments · Fixed by #373
Closed

Solve Rubocop warnings #250

nunosilva800 opened this issue Oct 6, 2017 · 5 comments · Fixed by #373
Labels
good first issue Hacktoberfest https://hacktoberfest.digitalocean.com

Comments

@nunosilva800
Copy link
Collaborator

nunosilva800 commented Oct 6, 2017 •
edited
Loading

Go through .rubocop_todo.yml and fix those issues :)

Just remove a line, run rubocop and you should see the warning/error.
@kyl0b1te
Copy link

kyl0b1te commented Oct 7, 2017

@Onumis I'll check it out

@ericboehs
Copy link

I'll run the auto correct for SpecialGlobalVars.

@kyl0b1te
Copy link

@ericboehs you can do everything, I'm really busy now

@nunosilva800 nunosilva800 mentioned this issue Oct 19, 2017
Closed
@tibbon
Copy link

tibbon commented May 17, 2018

On master currently when I clear the .rubocop_todo.yml file completely, I don't get any failures.

@nunosilva800
Copy link
Collaborator Author

@tibbon if you are using latest rubocop, then we need to update the AllCops/Include setting in .rubocop.yml file

See rubocop/rubocop#4247 (comment)

@harman28 harman28 mentioned this issue Oct 6, 2018
Merged
@nunosilva800 nunosilva800 added the Hacktoberfest https://hacktoberfest.digitalocean.com label Oct 24, 2019
@sl4vr sl4vr mentioned this issue Nov 6, 2020
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Hacktoberfest https://hacktoberfest.digitalocean.com
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Solve rubocop warnings sl4vr/rubycritic
4 participants
@ericboehs @tibbon @nunosilva800 @kyl0b1te