Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Smell cost explanation? #426

Open
markadrianagbuya opened this issue Jan 23, 2023 · 0 comments
Open

Smell cost explanation? #426

markadrianagbuya opened this issue Jan 23, 2023 · 0 comments

Comments

@markadrianagbuya
Copy link

Recently I modified the reek configuration to ignore some smells in some directories. I noticed that while the number of code smells for the files changed, the overall score didn't change. This was unexpected for me.

After diving deeper, I see that the cost of a Reek smell is 0. If I understand correctly, this means that smells found by Reek, don't have an impact on the cost, rating or overall score. If this is the case, this was unintuitive as our team have been trying to improve the score by address a lot of the reek smells.

Is there an explanation or documentation that summarises the idea behind the scoring? I have read the Core Metrics, Score and Rating and Code Climate Score Doc however, I feel it would be good to explicitly describe how the cost is determined and explicitly describe the intentions behind the cost and weights (i.e., why reek smells are 0 and why flog and flay costs are X).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant