Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The pnpm-lock.yaml is misleading #375

Closed
nhynes opened this issue Sep 28, 2022 · 0 comments · Fixed by #376
Closed

The pnpm-lock.yaml is misleading #375

nhynes opened this issue Sep 28, 2022 · 0 comments · Fixed by #376

Comments

@nhynes
Copy link
Contributor

nhynes commented Sep 28, 2022

Describe the bug
The pnpm-lock.yaml is not actually used any more. This is clear because this project is not buildable after pnpm install since the ethers transitive deps are imported, but not hoisted. This could be solved by "shamefully hoisting" deps by setting the npmrc config, but that largely defeats the point of pnpm.

To Reproduce

  1. clone the repo
  2. pnpm install --frozen-lockfile
  3. pnpm build
  4. observe errors about missing dependencies

Expected behavior
pnpm install && pnpm build to work, or for there not to be a pnpm-lock.yaml

versions

  • hardhat-deploy: master
  • hardhat: irrelevant
  • nodejs: 16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant