New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Require that files are valid UTF-8 #308

Open

jdforrester opened this issue Jul 13, 2020 · 2 comments

Member

jdforrester commented Jul 13, 2020

Not sure if we'd want this for all files, or just JSON files, but…

No obvious upstream rule for this (just the BOM one).

Member

edg2s commented Jul 13, 2020

Specifically JSON with "invalid" UTF-8 can cause PHP json_decode to throw, which is an MW-specific issue.

Member

edg2s commented Jul 16, 2020

I'm not sure how we would implement a test in JS that PHP json_decode will throw.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment