Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Translate RegExp's are too relaxed which can result in skipping replacements #69

Closed
TedSander opened this issue Sep 17, 2018 · 1 comment · Fixed by #70
Closed

Translate RegExp's are too relaxed which can result in skipping replacements #69

TedSander opened this issue Sep 17, 2018 · 1 comment · Fixed by #70
Assignees
@Krinkle
Labels
Type: Problem

Comments

@TedSander
Copy link

It is probably easier to show in code. The following CSS snippet will not flip both transforms:

drawer {
  transform: translate(-100%)
}
drawer {
  transform: translate(100%)
}

This seems to be because the transform RegExp is selecting too much. It will work if both or even one of the rules have a semi-colon after it:

drawer {
  transform: translate(-100%);
}
drawer {
  transform: translate(100%);
}

I'm not sure if it affects any other rules. This seems more problematic for compilers such as Sass which automatically removes the last semi-colon for properties to save some space.
@YairRand YairRand mentioned this issue Sep 17, 2018
Merged
@Krinkle Krinkle self-assigned this Sep 17, 2018
@TedSander
Copy link
Author

@Krinkle any update? would the patch work for this?

Krinkle pushed a commit that referenced this issue Oct 11, 2018
@YairRand @Krinkle
Fix bug where transform() didn't flip on semicolon-less property
f5b34a1 
Fixes #69.
Closes #70.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Krinkle Krinkle

Labels
Type: Problem
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix translate bug on semicolonless transforms YairRand/cssjanus
2 participants
@Krinkle @TedSander