Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--dist-url in build.js should be updated #404

Open
vjpr opened this issue May 11, 2022 · 0 comments
Open

--dist-url in build.js should be updated #404

vjpr opened this issue May 11, 2022 · 0 comments

Comments

@vjpr
Copy link

vjpr commented May 11, 2022

iohook/build.js

Lines 143 to 145 in 2297744

if (/^electron/i.test(runtime)) {
args.push('--dist-url=https://atom.io/download/electron');
}

Should be args.push('--dist-url=https://electronjs.org/headers');

From: https://www.electronjs.org/docs/latest/tutorial/using-native-node-modules#manually-building-for-electron

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant