Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"git my" not working properly #29

Open
carlca opened this issue Jul 21, 2017 · 8 comments
Open

"git my" not working properly #29

carlca opened this issue Jul 21, 2017 · 8 comments

Comments

@carlca
Copy link

carlca commented Jul 21, 2017

Using Github 1.7 + Alfred 3 on macOS 10.12.6 Sierra

Hi Will, I've probably done something wrong, but when I type git my, all I see is entries for Google, Amazon and Wikipedia. I've setup the credentials with github username <username> and github password <password> and I've entered github test and got the message saying the test was successful. I've double checked on the github.com website that my credentials are correct so I don't know what the problem is. Can you help?

Looking more closely at the other issues, I think it's because I'm using Alfred 3. Any idea when a version for A3 will be ready? Thanks.

@eibrahim
Copy link

I am having the same issues, I forked the code and tried to fix it. If you can point me in the right direction, I can fix and issue a PR.

@iamstevendao
Copy link

Just confirm that I have the same issue, hope the team will update it to be able to work with Alfred 3 soon.

@schwemmer
Copy link

I have the same issue with Alfred 4. Apparently this is no longer working for years now. Taking a closer look at the README, I see now that it requires Alfred 2. Too bad, this would have been quite useful.

@willfarrell
Copy link
Owner

Someone, like to write a PR to fix?

@schwemmer
Copy link

I am new to Alfred (second day) and never used the Github API. Any clues where to start? Is it that the Github API has changed or is the problem an incompatibility between the Alfred versions?

@schwemmer
Copy link

schwemmer commented Sep 10, 2020

The debugging output says:

mkdir: /Users/<username>/Library/Caches/com.runningwithcrayons.Alfred-2/Workflow Data: No such file or directory
2020-09-10 22:13:11.951 defaults[77496:5848813] 
The domain/default pair of (/Users/<username>/Library/Application Support/Alfred 2/Workflow Data/com.farrell.github.alfredworkflow/settings.plist, github.proxy) does not exist

The issue here, I think, is the hard-coded path to Alfred 2 that no longer exists in Alfred versions 3 and 4, on lines 41 and 42 of workflows.php:

$this->cache = $this->home. "/Library/Caches/com.runningwithcrayons.Alfred-2/Workflow Data/".$this->bundle;
$this->data  = $this->home. "/Library/Application Support/Alfred 2/Workflow Data/".$this->bundle;

I could only find this official documentation: https://www.alfredapp.com/help/workflows/script-environment-variables/ which strangely lists the same paths, containing "Alfred 2".

alfred_workflow_cache and alfred_workflow_data

These are the recommended locations for volatile and non-volatile workflow data:

Cache: ~/Library/Caches/com.runningwithcrayons.Alfred-2/Workflow Data/[bundle id]
Data: ~/Library/Application Support/Alfred 2/Workflow Data/[bundle id]

@schwemmer
Copy link

I more or less figured out how to build the workflow (where are the docs for this?) and adapted those paths (Alfred-2 => Alfred and Alfred 2 => Alfred) which gets rid of the first two errors, but there are more errors after that. I'll look into it but not sure if I can fix it.

@schwemmer
Copy link

It's a pretty complicated combination of PHP code, bash scripts, Github API and Alfred internals. Also, I can't find proper documentation about how to develop. It's very tedious to manually archive the files, rename the archive and import it every single time you change a line of code. var_dump() does not seem to work either. In short, it's too complicated for me. Sorry I can't help with a PR. I see why you haven't updated this yet, it's not trivial for sure!

For now I just created a custom web search that searches Github which is good enough for me for the moment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants